Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't Show Failed Upload Message For Same File and Handle Local Behavior #14410

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Jan 15, 2025

  • Tests written, or not not needed

• Removes messages related to failed uploads
• Manages local behavior in cases of upload synchronization conflicts and when the remote directory contains the same file

@alperozturk96 alperozturk96 linked an issue Jan 15, 2025 that may be closed by this pull request
4 tasks
@alperozturk96 alperozturk96 removed the request for review from tobiasKaminsky January 15, 2025 13:52
@alperozturk96 alperozturk96 changed the title Don't Show Failed Upload Message For Same File Don't Show Failed Upload Message For Same File and Handle Failed Upload Jan 15, 2025
@alperozturk96 alperozturk96 changed the title Don't Show Failed Upload Message For Same File and Handle Failed Upload Don't Show Failed Upload Message For Same File and Handle Local Behavior Jan 15, 2025
@alperozturk96 alperozturk96 force-pushed the dont-show-failed-upload-message-for-same-file branch from 799df72 to ab190f5 Compare January 15, 2025 14:01
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14410.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

Copy link

Codacy

Lint

TypemasterPR
Warnings5555
Errors33

SpotBugs

CategoryBaseNew
Bad practice6565
Correctness5858
Dodgy code294294
Experimental11
Internationalization77
Malicious code vulnerability11
Multithreaded correctness77
Performance5353
Security1818
Total504504

@bilogic
Copy link

bilogic commented Jan 17, 2025

thanks for the PR, it solves the problem, but because it is another fresh installation, I cannot re-use my config from the GA version or the DEV version and had to reconfigure the entire app from scratch...

@bilogic
Copy link

bilogic commented Jan 20, 2025

@alperozturk96

  • I have a screen recording MP4 in my /storage/emulated/0/Movies and some PNGs /storage/emulated/0/Pictures/Screenshots folder
  • It has been over 10 minutes and both still refuses to auto upload... how to find out why delay?
  • There are no visible clues as to what the issue might be, thus my report is not as helpful

I have tried:

  1. Re-enabling the folder's auto upload
  2. Pulling down to refresh the page
  3. Exit and enter the page
  4. Changing behavior of Original file will be... and back to delete

Given the dire situation, It is better to add a manual upload for each folder triggered by go to the 3 dot menu and clicking Upload

@alperozturk96
Copy link
Collaborator Author

@bilogic Thank you for the message. That might be a some other problem. Since it's not related with this PR. Please create a separate issue. So we can continue to discuss from that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Same file already exists, no conflict detected toast infinitely
2 participants